Skip to content

Conversation

@Alxiice
Copy link
Contributor

@Alxiice Alxiice commented Sep 17, 2025

Warning

After #2861

Description

Adds the interface for the messages that was missing in previous PR
Peek 2025-09-16 21-09
Note: since this gif I changed the copy feature to copy lines like a standard log instead of a dict

@codecov
Copy link

codecov bot commented Sep 17, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 79.41%. Comparing base (9b003f6) to head (ea333b7).
⚠️ Report is 4 commits behind head on develop.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #2891   +/-   ##
========================================
  Coverage    79.41%   79.41%           
========================================
  Files           51       51           
  Lines         6987     6987           
========================================
  Hits          5549     5549           
  Misses        1438     1438           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Alxiice Alxiice added this to the Meshroom 2026.1.0 milestone Sep 17, 2025
@Alxiice Alxiice added feature new feature (proposed as PR or issue planned by dev) UI labels Sep 17, 2025
Base automatically changed from dev/reload_plugins_popup to develop September 19, 2025 07:29
Copy link
Contributor

@cbentejac cbentejac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The comments are just a bit of nit-picking, otherwise everything runs smoothly and is really nice. Well done!

@Alxiice Alxiice force-pushed the dev/status_messages_interface branch from 87d5095 to 655b4ef Compare September 26, 2025 16:05
@Alxiice Alxiice requested a review from cbentejac September 26, 2025 16:06
@Alxiice Alxiice force-pushed the dev/status_messages_interface branch from 655b4ef to 38b14ca Compare September 29, 2025 18:13
@Alxiice Alxiice force-pushed the dev/status_messages_interface branch from 38b14ca to ea333b7 Compare September 30, 2025 10:42
@cbentejac cbentejac merged commit aabe589 into develop Sep 30, 2025
4 checks passed
@cbentejac cbentejac deleted the dev/status_messages_interface branch September 30, 2025 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature new feature (proposed as PR or issue planned by dev) UI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants